Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: replace es-x/no-array-prototype-includes with unicorn/prefer-includes #2125

Merged
merged 6 commits into from
Dec 11, 2024
Merged

eslint: replace es-x/no-array-prototype-includes with unicorn/prefer-includes #2125

merged 6 commits into from
Dec 11, 2024

Conversation

NovemLinguae
Copy link
Member

@NovemLinguae NovemLinguae commented Dec 9, 2024 •
edited
Loading

after discussion in #2101, removes the prohibition on using .includes()

also, adds a prohibition on using .indexOf !== -1, and applies the autofixes

@NovemLinguae NovemLinguae changed the title eslint: turn off es-x/no-array-prototype-includes eslint: replace es-x/no-array-prototype-includes with unicorn/prefer-includes Dec 9, 2024
@github-actions github-actions bot added Module: morebits The morebits.js library Module: twinkle The twinkle.js global gadget file labels Dec 9, 2024
@NovemLinguae NovemLinguae merged commit ad012f7 into wikimedia-gadgets:master Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Module: batch The three batch modules and deprod Module: block Module: config Module: morebits The morebits.js library Module: prod Module: protect Module: rollback Module: speedy Module: tag Module: twinkle The twinkle.js global gadget file Module: unlink Module: warn Module: xfd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NovemLinguae